ci(deploy): per-job permissions for docs + docker#2473
Open
arpitjain099 wants to merge 2 commits into
Open
Conversation
- docs job: contents: write — needed because crazy-max/ghaction-github-pages@v3 pushes built docs to gh-pages using GITHUB_TOKEN. - docker job: contents: read — DockerHub push uses secrets.DOCKER_USERNAME/DOCKER_TOKEN, so GITHUB_TOKEN only needs read access to the checkout. Matches the per-workflow permissions pattern already in stable.yml and nightly.yml. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
e9d9992 to
58796af
Compare
Author
|
Hi @antoniovicente, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
Author
|
Following up to see if this is still worth pursuing. Happy to iterate if it is. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares per-job
permissionsblocks on the two jobs indeploy.yml:crazy-max/ghaction-github-pages@v3to push the generated rustdoc to thegh-pagesbranch, so it needscontents: writefor the defaultGITHUB_TOKEN.DOCKER_USERNAME+DOCKER_TOKENand runsmake docker-publish— the GitHub token isn't used after checkout, socontents: readis sufficient.Other workflows here (
stable.yml,nightly.yml,semgrep.yml) already declare their own permissions blocks. YAML validated withyaml.safe_load.